Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
buftarget
package, which provides path targeting informationfor a storage bucket:
BucketTargeting
provides information on aControllingWorkspace
if one wasfound in the bucket, the input path, target paths, and target exclude paths
TerminateAtControllingWorkspace
has been consolidated to this packageThe way the package is used is that when
bufctl.Controller
callsbuffetch/internal.Reader
to get the storage bucket ,
buffetch/internal.Reader
now also returnsbuftarget.BucketTargeting
alongside the bucket.
bufworkspace.WorkspaceProvider
then handles the workspace and moduletargeting using
buftarget.BucketTargeting
. This removes the need to set input path, target paths,and target exclude paths as workspace provider options, and is instead just passed through
workspaceTargeting
andmoduleTargeting
.This change also introduces some fallback logic in
workspaceTargeting
for inputs that did notresolve to a controlling workspace.
Lastly, tests that were skipped previously for path/exclude-path behavior issues have been
unskipped and resolved accordingly.